Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for custom code push client headers, add x-cli-version header to CLI requests #1913

Merged
merged 10 commits into from
Apr 16, 2024

Conversation

bryanoltman
Copy link
Contributor

Description

  • Adds support for additional headers in code push client requests
  • Adds the x-cli-version to all code push client request headers made by the CLI

Part of #1910

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3dc991c) to head (2dc1e6d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #1913      +/-   ##
===========================================
+ Coverage   99.98%   100.00%   +0.01%     
===========================================
  Files         174       174              
  Lines        5476      5496      +20     
===========================================
+ Hits         5475      5496      +21     
+ Misses          1         0       -1     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (+0.02%) ⬆️
shorebird_code_push_client 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felangel felangel changed the title feat: add x-cli-verison header to code push client requests feat(shorebird_cli): add x-cli-version header Apr 16, 2024
@bryanoltman bryanoltman changed the title feat(shorebird_cli): add x-cli-version header feat: add support for custom code push client headers, add x-cli-version header to CLI requests Apr 16, 2024
@felangel felangel merged commit 81c250c into main Apr 16, 2024
15 checks passed
@felangel felangel deleted the bo/cli-version-header branch April 16, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants