Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shorebird_cli): close input stream when extracting cache artifacts #1923

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

bryanoltman
Copy link
Contributor

Description

Possibly the cause of the e2e failures in https://github.com/shorebirdtech/shorebird/actions/runs/8725954542/job/23940129912

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@bryanoltman bryanoltman enabled auto-merge (squash) April 17, 2024 18:08
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.85%. Comparing base (0fec75d) to head (d42c064).

Additional details and impacted files
@@             Coverage Diff              @@
##              main    #1923       +/-   ##
============================================
- Coverage   100.00%   87.85%   -12.15%     
============================================
  Files          174      174               
  Lines         5503     5500        -3     
============================================
- Hits          5503     4832      -671     
- Misses           0      668      +668     
Flag Coverage Δ
shorebird_cli 84.33% <100.00%> (-15.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman merged commit b1d963e into main Apr 17, 2024
10 of 11 checks passed
@bryanoltman bryanoltman deleted the bo/close-input-stream branch April 17, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants