Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shorebird_cli): improve patch output when release uses non-default flutter version #1932

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

bryanoltman
Copy link
Contributor

Description

When patching a release that uses a version of Flutter older than the default, we show the message:

The release you are trying to patch was built with a different version of Flutter.

Release Flutter Revision: 03e895ee09dfbb9c18681d103f4b27671ff65429
Current Flutter Revision: 47571af6a3acdebedf88255099ff1de1c3324049

It looks like an error, but it's not. This has confused several users.

This PR changes the message to simply say Release was built with Flutter revision 03e895ee09dfbb9c18681d103f4b27671ff65429.

Fixes #1930

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link
Contributor

@eseidel eseidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also added a later message explaining what version of flutter we're using to patch with, so this might even just be redundant. regardless, lgtm.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3bd3f64) to head (d51ecbf).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1932   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          174       174           
  Lines         5495      5493    -2     
=========================================
- Hits          5495      5493    -2     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman merged commit ccfeb87 into main Apr 18, 2024
11 checks passed
@bryanoltman bryanoltman deleted the bo/release-flutter-version-log branch April 18, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Improve message when making a patch with non default flutter version
3 participants