Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding debug-linker flag to patch ios command #1934

Merged
merged 7 commits into from
Apr 22, 2024

Conversation

erickzanardo
Copy link
Contributor

@erickzanardo erickzanardo commented Apr 18, 2024

Description

Adds a debug-linker flag to the shorebird patch ios command generate debug data in the aot tools.

WIP: Manual test missing.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1d1febf) to head (b3dafca).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1934   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          174       174           
  Lines         5493      5506   +13     
=========================================
+ Hits          5493      5506   +13     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm but I think we could improve the archiving flow to first write to a temp dir and then zip and move to the build dir. Lmk what you think 👍

);

if (dumpDebugInfo && dumpDebugInfoDir != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (dumpDebugInfo && dumpDebugInfoDir != null) {
if (dumpDebugInfoDir != null) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By adding the dumpDebugInfoDir != null I can skip the unwrap one line below.

@erickzanardo erickzanardo merged commit 7652dc6 into main Apr 22, 2024
11 checks passed
@erickzanardo erickzanardo deleted the feat/adding-debug-link-to-ios-patch branch April 22, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants