-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding debug-linker flag to patch ios command #1934
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1934 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 174 174
Lines 5493 5506 +13
=========================================
+ Hits 5493 5506 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
packages/shorebird_cli/lib/src/commands/patch/patch_ios_command.dart
Outdated
Show resolved
Hide resolved
packages/shorebird_cli/lib/src/commands/patch/patch_ios_command.dart
Outdated
Show resolved
Hide resolved
packages/shorebird_cli/lib/src/commands/patch/patch_ios_command.dart
Outdated
Show resolved
Hide resolved
packages/shorebird_cli/lib/src/commands/patch/patch_ios_command.dart
Outdated
Show resolved
Hide resolved
packages/shorebird_cli/test/src/executables/aot_tools_test.dart
Outdated
Show resolved
Hide resolved
packages/shorebird_cli/test/src/executables/aot_tools_test.dart
Outdated
Show resolved
Hide resolved
packages/shorebird_cli/test/src/executables/aot_tools_test.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm but I think we could improve the archiving flow to first write to a temp dir and then zip and move to the build dir. Lmk what you think 👍
Co-authored-by: Felix Angelov <felix@shorebird.dev>
packages/shorebird_cli/lib/src/commands/patch/patch_ios_command.dart
Outdated
Show resolved
Hide resolved
); | ||
|
||
if (dumpDebugInfo && dumpDebugInfoDir != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (dumpDebugInfo && dumpDebugInfoDir != null) { | |
if (dumpDebugInfoDir != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By adding the dumpDebugInfoDir != null
I can skip the unwrap
one line below.
Description
Adds a
debug-linker
flag to theshorebird patch ios
command generate debug data in the aot tools.WIP: Manual test missing.
Type of Change