docs: add initial Dart style guide #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
reviewed
Apr 24, 2024
felangel
reviewed
Apr 24, 2024
felangel
reviewed
Apr 24, 2024
felangel
reviewed
Apr 25, 2024
| This guide is a supplement to | ||
| [Effective Dart](https://dart.dev/guides/language/effective-dart) and should be | ||
| read in the same way. If there is a conflict between this guide and Effective | ||
| Dart, this guide takes precedence. |
There was a problem hiding this comment.
Suggested change
| Dart, this guide takes precedence. | |
| Dart, this guide takes precedence. | |
| *Note: This style guide only defines rules which are enforced via lint rules.* |
There was a problem hiding this comment.
Which are NOT enforced by lint rules, you mean?
There was a problem hiding this comment.
Updated to say:
This style guide only defines rules which are not enforced via lint rules. If possible, prefer using lint rules to enforce style.
There was a problem hiding this comment.
Yup sorry I was clearly tired when I reviewed 😴
felangel
reviewed
Apr 25, 2024
felangel
reviewed
Apr 25, 2024
felangel
approved these changes
Apr 25, 2024
Co-authored-by: Felix Angelov <felix@shorebird.dev>
Co-authored-by: Felix Angelov <felix@shorebird.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the start of a Dart style guide.
Type of Change