Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert " update cache artifacts on every command run" #1975

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

felangel
Copy link
Contributor

@felangel felangel commented Apr 25, 2024

Description

Reverts #1958

Reverting this change because for customers patching or releasing using older flutter revisions, this change results in the cache only downloading artifacts for the latest stable engine revision instead of the engine revision being used to patch/release.

Also filed #1976 to prevent this type of regression in the future.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the bug Something isn't working label Apr 25, 2024
@felangel felangel self-assigned this Apr 25, 2024
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (65e0e56) to head (3856414).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1975   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          177       177           
  Lines         5562      5564    +2     
=========================================
+ Hits          5562      5564    +2     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felangel felangel merged commit 5651ac1 into main Apr 25, 2024
11 checks passed
@felangel felangel deleted the fix/revert-cache-update branch April 25, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants