Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(shorebird_cli): refactor shorebird release in favor of shorebird release android #541

Merged
merged 3 commits into from
May 24, 2023

Conversation

felangel
Copy link
Contributor

@felangel felangel commented May 24, 2023

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel self-assigned this May 24, 2023
@@ -76,6 +74,12 @@ make smaller updates to your app.

@override
Future<int> run() async {
logger.warn(
'''
"shorebird release" is deprecated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"shorebird release" is deprecated.
"shorebird release" is deprecated and will be removed in a future release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally didn't do that because the command "shorebird release" technically won't be removed 🤣

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to adjust the wording though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahaha fair enough!

@felangel felangel merged commit 146f84b into main May 24, 2023
5 checks passed
@felangel felangel deleted the refactor/deprecate-shorebird-release branch May 24, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants