feat(shorebird_cli): shorebird release ios scaffold
#543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanoltman
reviewed
May 24, 2023
| super.auth, | ||
| super.buildCodePushClient, | ||
| super.cache, | ||
| super.validators, |
There was a problem hiding this comment.
Apologies if I'm repeating myself on this, but we'll need to update how we provide validators, since the only default validator is the AndroidInternetPermission validator, which doesn't apply here (and we'll likely want something similar to that, but for iOS).
There was a problem hiding this comment.
Yup sg will address in a separate PR 👍
bryanoltman
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
shorebird release iosscaffold (part of cli / server support for iOS #518)Type of Change