Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: downloadUpdateIfAvailable should return success/failure #123

Open
lucky1213 opened this issue Feb 23, 2024 · 5 comments
Open

feat: downloadUpdateIfAvailable should return success/failure #123

lucky1213 opened this issue Feb 23, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@lucky1213
Copy link

No description provided.

@eseidel
Copy link
Contributor

eseidel commented Feb 23, 2024

Sounds like you would like:
https://pub.dev/documentation/shorebird_code_push/latest/shorebird_code_push/ShorebirdCodePush/downloadUpdateIfAvailable.html
To return some value to indicate that it actually did an install or not, correct?

@eseidel eseidel changed the title Hope downloadUpdateIfAvailable returns patch installation results feat: downloadUpdateIfAvailable should return success/failure Feb 23, 2024
@eseidel eseidel added the enhancement New feature or request label Feb 23, 2024
@eseidel
Copy link
Contributor

eseidel commented Feb 23, 2024

@luatvudinh
Copy link

I suspect the workaround for now would be to call https://pub.dev/documentation/shorebird_code_push/latest/shorebird_code_push/ShorebirdCodePush/isNewPatchReadyToInstall.html right after.

Do you have a plan to enhance this flow @eseidel ? We did manual flow but it was not clear enough for case exception occurring.
At the moment, we were retrying several times before force user to download the latest version.

@eseidel
Copy link
Contributor

eseidel commented Apr 9, 2024

shorebirdtech/shorebird#123 is also related.

I think we don't yet have a plan as to exactly what to build here. If you have suggestions (ideally with imaginary code) as to how you'd like this API to work, we'd welcome suggestions.

@luatvudinh
Copy link

Thanks @eseidel. The issue you mentioned is enough for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants