docs: update building_engine.md #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanoltman
changed the title
felangel
approved these changes
May 9, 2023
eseidel
approved these changes
May 9, 2023
|
|
||
| ```shorebird --local-engine-src-path=$HOME/Documents/GitHub/engine --local-engine=android_release_arm64 run``` | ||
| ```bash | ||
| $PATH_TO_ENGINE_SRC="$HOME/Documents/GitHub/engine/src" |
There was a problem hiding this comment.
Not sure why to do this? :) but lgtm
There was a problem hiding this comment.
It's functionally the same, this is just to make the following line copy-paste-able for others
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates based on @bryanoltman's first time going through the instructions.
Type of Change