Skip to content
This repository has been archived by the owner on Dec 27, 2020. It is now read-only.

Graceful shutdown #101

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Graceful shutdown #101

wants to merge 12 commits into from

Conversation

arberiii
Copy link
Member

Closes #67. Note that mux.Server always shutdowns gracefully and for GRPC service, we can call the GracefulStop method.

@magicoder10
Copy link
Member

This is not enough. We need to extend the functionality and to allow developers to control what they want to process when receiving shutdown signal.

@magicoder10
Copy link
Member

https://medium.com/honestbee-tw-engineer/gracefully-shutdown-in-go-http-server-5f5e6b83da5a

@arberiii
Copy link
Member Author

I will check it out, thank you!

@pull-request-size pull-request-size bot added size/M and removed size/S labels May 28, 2020
@pull-request-size pull-request-size bot added size/L and removed size/M labels May 28, 2020
@magicoder10
Copy link
Member

The intended behavior for graceful shutdown:

  1. Server stops accepting new requests
  2. Wait for all current requests to finish
  3. Clean up system resources
  4. Shutdown the server.

Need to think about how can we make this happen.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate graceful shutdown into app framework
2 participants
@arberiii @magicoder10