This repository has been archived by the owner on Oct 17, 2020. It is now read-only.
Add instrumentation for Search API #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arberiii
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #885 +/- ##
==========================================
+ Coverage 44.17% 53.42% +9.25%
==========================================
Files 120 132 +12
Lines 2420 3165 +745
Branches 154 154
==========================================
+ Hits 1069 1691 +622
- Misses 1305 1406 +101
- Partials 46 68 +22
Continue to review full report at Codecov.
|
magicoder10
suggested changes
Jun 26, 2020
| http.Error(w, err.Error(), http.StatusInternalServerError) | ||
| return | ||
| } | ||
|
|
||
| w.Write(respBody) | ||
| i.SearchSucceed() |
There was a problem hiding this comment.
We need to track the keyword being searched, in which city and at what time so that we can analyze and determine the new features we want to build in order to better serve the users. This means we need to include analytics.
arberiii
commented
Jun 26, 2020
magicoder10
suggested changes
Jun 26, 2020
| userID := i.getUserID(user) | ||
| props := map[string]string{ | ||
| "keywords": keywords, | ||
| "time": t.String(), |
There was a problem hiding this comment.
Time is automatically tracked by analytics API. I wonder whether we can track the list of resources being search also. Let's separate them with ,.
… search-instrumenation
magicoder10
suggested changes
Jun 26, 2020
magicoder10
approved these changes
Jun 26, 2020
arberiii
force-pushed
the
search-instrumenation
branch
from
3b39848
to
936e982
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds instrumentation to the search API. It has only two metrics: search-failed and search-succeded.