Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: disputed boundaries #11

Merged
merged 4 commits into from Mar 9, 2023

Conversation

yetzt
Copy link
Contributor

@yetzt yetzt commented Feb 26, 2023

fixed version of #5 as proposed in shortbread-docs/#1

@Nakaner
Copy link
Contributor

Nakaner commented Mar 8, 2023

I pushed a commit onto your branch to make the things work as expected.

I build vector tiles for the boundary-lines layer of the Geofabrik Asia OSM extract. Blue lines have disputed=true, green lines disputed=false in the vector tiles.

The western half of Crimea is missing because it is outside the Asia clipping polygon. Boundary lines of the Kashmir and Ladakh region are missing because type=boundary was set on the boundary was (I removed the tags from OSM today).

palestine

india

armenia

I will investigate whether ignoring relations with boundary=disputed and admin_level>4 will improve the result. Many of the relations with boundary=disputed do not have admin_level=*, they will not be ignored.

@yetzt
Copy link
Contributor Author

yetzt commented Mar 8, 2023

ah, good point, i was only really interested in looking at admin_level=2.

@Nakaner
Copy link
Contributor

Nakaner commented Mar 8, 2023

If boundary=disputed with admin_level=2/3/4 or missing admin_level are accepted only, some boundary lines around West bank loose their disputed=true.

west-bank

@Nakaner Nakaner merged commit 1dabbed into shortbread-tiles:main Mar 9, 2023
@yetzt yetzt deleted the patch-boundaries-disputed branch March 9, 2023 12:06
Nakaner referenced this pull request in shortbread-tiles/shortbread-docs Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants