Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle multiple tabs #154

Merged
merged 3 commits into from
Jan 29, 2023
Merged

feat: handle multiple tabs #154

merged 3 commits into from
Jan 29, 2023

Conversation

shortcuts
Copy link
Owner

@shortcuts shortcuts commented Jan 27, 2023

📃 Summary

closes #152
closes #83

This PR provides a refactor of the internal state handling to support a NoNeckPain instance per tab.

The goal is to provide an even more seamless experience when working with tabs with the plugin enabled.

  • leverage tab instead of global state
  • fetch wins of the active tab instead of all wins
  • keep track of the active tab
  • skip enable/disable for the given tab not globally
  • ensure augroup is scoped to the tab
  • ensure color groups are scoped to the tab
  • ensure tests pass
  • add tabs tests

@shortcuts shortcuts self-assigned this Jan 27, 2023
@shortcuts shortcuts marked this pull request as draft January 27, 2023 10:04
@shortcuts shortcuts marked this pull request as ready for review January 28, 2023 22:34
@shortcuts shortcuts changed the title feat: scope state to tabs feat: handle multiple tabs Jan 28, 2023
@shortcuts shortcuts merged commit 3f0efca into main Jan 29, 2023
@shortcuts shortcuts deleted the feat/scope-state-to-tabs branch January 29, 2023 10:53
shortcuts added a commit that referenced this pull request Jan 29, 2023
## 📃 Summary

follow up of #154

Some code cleanup after the tab feature
shortcuts pushed a commit that referenced this pull request Jan 29, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.6.0](v0.5.0...v0.6.0)
(2023-01-29)


### Features

* handle multiple tabs
([#154](#154))
([3f0efca](3f0efca))
* keep side buffers on vsplit
([#145](#145))
([0029fee](0029fee))
* keeps side buffers for current tab
([#150](#150))
([e513dc3](e513dc3))


### Bug Fixes

* cleanup after tab feature
([#158](#158))
([5fe00a0](5fe00a0))
* right color group never deleted
([#153](#153))
([fce7bcb](fce7bcb))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: plugin state per tab Allow enabling NoNeckPain per buffer
1 participant