Neotree close_if_last_window does not work

[sand4rt]

Steps to reproduce

1. open NNP
2. open neo-tree with close_if_last_window = true
3. close the window

Expected behavior

Neovim should close, but it doesn't. It likely detects that NNP is still open, preventing it to close

Environment

• Neovim version: 10
• no-neck-pain.nvim version: latest
• Plugin clash: neo-tree

[shortcuts]

Hey @sand4rt thanks for reporting the issue, would you mind describe the steps you've done to reproduce this? so far if I have the neo-tree open along with nnp and I :q on the centered buffer, it closes nvim properly

[shortcuts]

fix released here https://github.com/shortcuts/no-neck-pain.nvim/releases/tag/v1.14.0

[sand4rt]

Hi @shortcuts, just tested the latest release and the issue is still there:

issue.mov

nvim should close at the end, but it doesn't. It's probably because neo-tree does not think it's the last window because NNP is open.

[shortcuts]

Hi @shortcuts, just tested the latest release and the issue is still there:

issue.mov
nvim should close at the end, but it doesn't. It's probably because neo-tree does not think it's the last window because NNP is open.

oh that's weird it's exactly what I tried, i'll write a test case for this to see if it behaves differently

[shortcuts]

Hey @sand4rt would you mind letting me know if those steps reproduce your issue on your side? #366

[sand4rt]

hi @shortcuts, thanks for your reply. Im not sure how to reproduce the steps in #366? This is what i did:

1. :NoNeckPain -- open NNP
2. :Neotree -- open Neotree
3. <C-w><C-l> -- Move focus to the main window
4. :q -- close nvim and make sure close_if_last_window is was to true in Neotree
5. neovim should be closed

close_if_last_window in Neotree does work if NNP is not enabled btw.

[shortcuts]

hi @shortcuts, thanks for your reply. Im not sure how to reproduce the steps in #366? This is what i did:

it looks like what I've executed in the test suite, I'll change it to match your input 1:1 and see how it behaves

[shortcuts]

Screen.Recording.2024-05-31.at.09.59.52.mov

Here's a screen recording with the configuration I've used at the end

(width related options shouldn't matter here, they are only used for test cases and avoiding opening too-big instances)