New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backup-volfile-server(s) in mount provider #72

Merged
merged 1 commit into from Oct 12, 2016

Conversation

Projects
None yet
2 participants
@vchung-nz
Contributor

vchung-nz commented Oct 10, 2016

Fix case statement and use backupvolfile_servers parameter for multiple servers.

Show outdated Hide outdated providers/mount.rb Outdated
Show outdated Hide outdated CHANGELOG.md Outdated
Show outdated Hide outdated CHANGELOG.md Outdated
@shortdudey123

This comment has been minimized.

Show comment
Hide comment
@shortdudey123

shortdudey123 Oct 10, 2016

Owner

Sorry, one last thing...
Can you rebase on master then move the changelog entry to the Unreleased section?
Will merge after that 😄

Owner

shortdudey123 commented Oct 10, 2016

Sorry, one last thing...
Can you rebase on master then move the changelog entry to the Unreleased section?
Will merge after that 😄

@shortdudey123

This comment has been minimized.

Show comment
Hide comment
@shortdudey123

shortdudey123 Oct 10, 2016

Owner

Can you fix the merge conflict?

Conflicting files
CHANGELOG.md
Owner

shortdudey123 commented Oct 10, 2016

Can you fix the merge conflict?

Conflicting files
CHANGELOG.md
@vchung-nz

This comment has been minimized.

Show comment
Hide comment
@vchung-nz

vchung-nz Oct 12, 2016

Contributor

File updated

Contributor

vchung-nz commented Oct 12, 2016

File updated

@shortdudey123

This comment has been minimized.

Show comment
Hide comment
@shortdudey123

shortdudey123 Oct 12, 2016

Owner

can you squash the commits so the sync with master is not in the commit history? thanks!

Owner

shortdudey123 commented Oct 12, 2016

can you squash the commits so the sync with master is not in the commit history? thanks!

@vchung-nz vchung-nz closed this Oct 12, 2016

@vchung-nz vchung-nz reopened this Oct 12, 2016

@shortdudey123 shortdudey123 merged commit 71e5f58 into shortdudey123:master Oct 12, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment