Check both overlapping keys and quoting

- Remove the short circuit evaluation between checking overlapping keys and quoting. Signed-off-by: Hansuk Hong <flavono123@gmail.com>
shortdudey123 · Aug 15, 2018 · 3f71855 · 3f71855
1 parent 7e408ef
commit 3f71855
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/yamllint/linter.rb b/lib/yamllint/linter.rb
@@ -96,8 +96,10 @@ def check_filename(filename)
     def check_data(yaml_data, errors_array)
       valid = check_not_empty?(yaml_data, errors_array)
       valid &&= check_syntax_valid?(yaml_data, errors_array)
-      valid &&= check_overlapping_keys?(yaml_data, errors_array)
-      valid &&= check_quoting_valid?(yaml_data, errors_array)
+      valid &&= [
+        check_overlapping_keys?(yaml_data, errors_array),
+        check_quoting_valid?(yaml_data, errors_array)
+      ].all? {|valid| valid}
 
       valid
     end