Fix rubocop issues using --auto-correct #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,6 +6,7 @@ This file is used to list changes made in each version of the YamlLint gem. | |||
| - **[PR #28](https://github.com/shortdudey123/yamllint/pull/28)** - Fix Security/YAMLLoad rubocop offense | |||
| - **[PR #29](https://github.com/shortdudey123/yamllint/pull/29)** - Update TraviCI Rubies | |||
| - **[PR #30](https://github.com/shortdudey123/yamllint/pull/30)** - Fix Style/PercentLiteralDelimiters offense | |||
| - **[PR #39](https://github.com/shortdudey123/yamllint/pull/39)** - Fix trollop deprecation warning | |||
There was a problem hiding this comment.
Can you copy the title of the PR from GitHub to here instead?
| ### | ||
| # | ||
| # YamlLint checks YAML files for correct syntax | ||
| module YamlLint | ||
| VERSION = '0.0.9'.freeze | ||
| VERSION = '0.0.10' |
There was a problem hiding this comment.
Please revert version bump as this will happen on the next gem release.
|
Thanks for the PR! Can you rebase on master and verify this still passes with the newest rubocop? |
Merged
Merged
|
Used #48 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for fixing all the issues reported by the most recent release of rubocop which is 0.71
rvm --create ruby-2.6.3@yamllint --ruby-version
$ rubocop --version
0.71.0
After --auto-correct
$ rubocop
Inspecting 13 files
.............
13 files inspected, no offenses detected