Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add django 4 to tox matrix #77

Merged
merged 1 commit into from
Mar 26, 2022
Merged

Add django 4 to tox matrix #77

merged 1 commit into from
Mar 26, 2022

Conversation

shosca
Copy link
Owner

@shosca shosca commented Mar 25, 2022

No description provided.

@shosca shosca force-pushed the django4 branch 6 times, most recently from 40e6565 to a5f896f Compare March 25, 2022 23:44
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 25, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.07%.

Quality metrics Before After Change
Complexity 0.75 ⭐ 0.83 ⭐ 0.08 👎
Method Length 29.62 ⭐ 30.05 ⭐ 0.43 👎
Working memory 5.57 ⭐ 5.55 ⭐ -0.02 👍
Quality 87.66% 87.59% -0.07% 👎
Other metrics Before After Change
Lines 269 281 12
Changed files Quality Before Quality After Quality Change
rest_witchcraft/filters.py 81.58% ⭐ 81.58% ⭐ 0.00%
tests/test_routers.py 89.42% ⭐ 89.18% ⭐ -0.24% 👎
tests/urls/testhyperlinkedidentityfield.py 99.33% ⭐ 97.50% ⭐ -1.83% 👎
tests/urls/testhyperlinkedidentityfieldcomposite.py 99.33% ⭐ 97.50% ⭐ -1.83% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
rest_witchcraft/filters.py SearchFilter.get_schema_fields 0 ⭐ 41 ⭐ 10 😞 77.94% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling dce32f1 on django4 into 42278a9 on master.

@shosca shosca merged commit 72a2936 into master Mar 26, 2022
@shosca shosca deleted the django4 branch March 26, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants