Disable vertical paging in reader

Google has yet to fix their Webview interop with Compose, thus this action must be taken for UX. #198
shosetsuorg · Jul 7, 2022 · 8aa0c38 · 8aa0c38
1 parent 907b2b2
commit 8aa0c38
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/android/src/main/java/app/shosetsu/android/common/SettingKey.kt b/android/src/main/java/app/shosetsu/android/common/SettingKey.kt
@@ -116,7 +116,7 @@ sealed class SettingKey<T : Any>(val name: String, val default: T) {
 	/**
 	 * Instead of vertically moving between chapters, do a horizontal move
 	 */
-	object ReaderHorizontalPageSwap : BooleanKey("readerHorizontalPaging", true)
+	object ReaderHorizontalPageSwap : BooleanKey("readerHorizontalPaging_force", true)
 
 	/**
 	 * The reader smoothly moves between chapters

diff --git a/android/src/main/java/app/shosetsu/android/ui/reader/ChapterReader.kt b/android/src/main/java/app/shosetsu/android/ui/reader/ChapterReader.kt
@@ -196,7 +196,7 @@ class ChapterReader
 								item { viewModel.textSizeOption() }
 								//item { viewModel.tapToScrollOption() }
 								item { viewModel.volumeScrollingOption() }
-								item { viewModel.horizontalSwitchOption() }
+								//item { viewModel.horizontalSwitchOption() }
 								item { viewModel.invertChapterSwipeOption() }
 								item { viewModel.readerKeepScreenOnOption() }
 								item { viewModel.showReaderDivider() }

diff --git a/android/src/main/java/app/shosetsu/android/ui/settings/sub/ReaderSettings.kt b/android/src/main/java/app/shosetsu/android/ui/settings/sub/ReaderSettings.kt
@@ -230,9 +230,7 @@ fun ReaderSettingsContent(
 			)
 		}
 
-		item {
-			viewModel.horizontalSwitchOption()
-		}
+		//item { viewModel.horizontalSwitchOption() }
 
 		item {
 			ButtonSettingContent(