Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SG-29004 Upgrade deprecated azure pipelines machines #270

Merged
merged 4 commits into from Nov 24, 2022
Merged

SG-29004 Upgrade deprecated azure pipelines machines #270

merged 4 commits into from Nov 24, 2022

Conversation

000paradox000
Copy link
Contributor

@000paradox000 000paradox000 commented Nov 17, 2022 •
edited

  • Replace MacOS 10.11 with 12
  • Replace WIndows 2019 with 2022

mathurf
mathurf reviewed Nov 17, 2022
View reviewed changes
Copy link
Contributor

@mathurf mathurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why macOS-11, why not macOS-12 ?

mathurf
mathurf approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@mathurf mathurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julien-lang
Copy link
Contributor

We don't want to switch to Ubuntu 22 in this one as well?
No that this is the topic here but since you change the Windows image already and you aligned all images to the latest OS version in shotgunsoftware/tk-ci-tools#32, it would make sense to do it here too.

@000paradox000
Copy link
Contributor Author

We don't want to switch to Ubuntu 22 in this one as well? No that this is the topic here but since you change the Windows image already and you aligned all images to the latest OS version in shotgunsoftware/tk-ci-tools#32, it would make sense to do it here too.

Hi Julien thanks for the comment. In python-api we had to force ubuntu-20.04 for python-2.7 but the others images went well with latest versions. This will be solved once we deprecate python 2.

@julien-lang
Copy link
Contributor

In python-api we had to force ubuntu-20.04 for python-2.7

Oh I see. Thanks for the information.

@000paradox000 000paradox000 merged commit 62d2bb7 into master Nov 24, 2022
@000paradox000 000paradox000 deleted the SG-29004_validate_or_upgrade_if_necessary_deprecated_azure_pipelines_machines branch November 24, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathurf mathurf mathurf approved these changes

@NorberMV NorberMV Awaiting requested review from NorberMV

@vazquea vazquea Awaiting requested review from vazquea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@000paradox000 @julien-lang @mathurf