SG-31911 Add listen address argument #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the ability to specify a address other than localhost. Found that when running the webapp inside a container, all the requests were dropped because the default listen address was localhost and Docker requests come from a different interface.
|
Thank you for adding this. I ran into the same issue would appreciate to see this solution, or a similar one, to become part of the official version. |
|
Would be great to pull this in. About ready to roll out containerized bridges for our studios (with SSL). Right now, we're just running a sed replacement... |
carlos-villavicencio-adsk
changed the title
carlos-villavicencio-adsk
approved these changes
Oct 31, 2023
carlos-villavicencio-adsk
merged commit e65ae2c
into
shotgunsoftware:master
20 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to specify a address other than localhost.
Found that when running the webapp inside a container, all the requests
were dropped because the default listen address was localhost and Docker
requests come from a different interface.