SG-30534: First step to supporting PySide6 #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
staceyoue
commented
Jun 15, 2023
staceyoue
commented
- Provide a patch for PySide6 to work using the PySide (Qt4) interface
- Create a new qt6 module to import PySide6 directly (unpatched)
- Next step, deprecate PySide/Qt4 and make PySide6/Qt6 the default base
* Provide a patch for PySide6 to work using the PySide (Qt4) interface * Create a new qt6 module to import PySide6 directly (unpatched) * Next step, deprecate PySide/Qt4 and make PySide6/Qt6 the default base
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #898 +/- ##
==========================================
- Coverage 79.13% 78.86% -0.27%
==========================================
Files 177 179 +2
Lines 19495 19828 +333
==========================================
+ Hits 15428 15638 +210
- Misses 4067 4190 +123
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
julien-lang
reviewed
Jun 29, 2023
| @@ -0,0 +1,12 @@ | |||
| # Copyright (c) 2016 Shotgun Software Inc. | |||
There was a problem hiding this comment.
2016 -> 2023
Shotgun Software Inc -> Autodesk
To apply on each new file of this PR
| @@ -372,6 +446,10 @@ def _import_modules(self, interface_version_requested): | |||
| return pyside2 | |||
| except ImportError: | |||
| pass | |||
| elif interface_version_requested == self.QT6: | |||
| # TODO migrate qt base from Qt4 interface to Qt6 will require patching Qt5 as Qt6 | |||
There was a problem hiding this comment.
When would this TODO be taken care of? In this PR? In the next pyside6 PR? When we deprecate QT4?
| logger.debug("Requesting %s-like interface", interface) | ||
|
|
||
| # First try PySide6. | ||
| if interface_version_requested == self.QT4: |
There was a problem hiding this comment.
Is this a typo? (QT4 instead of QT6)?
There was a problem hiding this comment.
I don't think it is. It troubled me too but it makes sense when you read the full file.
julien-lang
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.