Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the test application #98

Merged
merged 2 commits into from
Oct 31, 2019
Merged

Fixes the test application #98

merged 2 commits into from
Oct 31, 2019

Conversation

jfboismenu
Copy link
Contributor

@jfboismenu jfboismenu commented May 2, 2019

The test application's config has been using templates ever since the webinar. However, the app picks the first project available to run it, but that project might not have the tank_name field set. Interestingly, it seems the app also requires roots.yml. It makes sense that it does, but I can't explain how it worked before now.

Amazingly, it seemed every person on the team who ran the app until now had a project with the tank_name field, so we never caught that problem! Now the app looks for a project with the tank_name field set. If None is found, an exception is raised and the test app aborts.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.15% when pulling a203ee0 on test_app_fix into 9aed39c on master.

Copy link
Contributor

@manneohrstrom manneohrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :shipit:

@jfboismenu jfboismenu merged commit d55b441 into master Oct 31, 2019
@jfboismenu jfboismenu deleted the test_app_fix branch October 31, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants