Skip to content

Commit

Permalink
Bench CI speedups (#814)
Browse files Browse the repository at this point in the history
  • Loading branch information
rukai committed Sep 21, 2022
1 parent 9d5b50c commit 486ca44
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
10 changes: 8 additions & 2 deletions .github/workflows/bench_run.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,14 @@ jobs:
- uses: actions/checkout@v3
- uses: Swatinem/rust-cache@v2
with:
# Unique key is used to avoid collisions with the Testing workflow
key: 'ubuntu-18.04-benchmark'
# PRs do not share caches, instead each PR initially pulls from the cache of the main branch for the first run.
# This workflow does not run on main, so to make use of a cache before this workflow has completed once on a PR,
# we need to manually recreate the key used by ubuntu-18.04 release builds.
shared-key: "ubuntu-18.04 - --release-build_and_test"
# TODO: while we want to leach off this cache we dont want to overwrite it
# so once something like https://github.com/Swatinem/rust-cache/issues/66 becomes available,
# we should do something like this:
# save-if: false
- name: Install ubuntu packages
run: shotover-proxy/build/install_ubuntu_packages.sh
- name: Run benchmarks
Expand Down
2 changes: 1 addition & 1 deletion shotover-proxy/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ generic-array = { version = "0.14", features = ["serde"] }

[dev-dependencies]
rayon = "1.5.1"
criterion = { git = "https://github.com/shotover/criterion.rs", branch = "version-0.4", version = "0.3", features = ["async_tokio", "html_reports"] }
criterion = { git = "https://github.com/shotover/criterion.rs", branch = "version-0.4", version = "0.3", features = ["async_tokio"] }
redis = { version = "0.21.0", features = ["tokio-comp", "cluster"] }
pcap = "0.10.0"
pktparse = { version = "0.7.0", features = ["serde"] }
Expand Down

0 comments on commit 486ca44

Please sign in to comment.