Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a metric that would measure the time taken from receiving a message and sending it back #984

Closed
yuzhouchen-instaclustr opened this issue Dec 23, 2022 · 3 comments

Comments

@yuzhouchen-instaclustr
Copy link
Collaborator

Currently the metric shotover_chain_latency does not take into account the time it takes to encode each message, it would be better if we can include that time as well.

@conorbros
Copy link
Member

Just to clarify, you mean include the time it takes to decode the message on arrival, process through the chain and encode at the end?

@rukai
Copy link
Member

rukai commented Dec 12, 2023

I investigated this yesterday/today and have a design that I'll go ahead with:

  • at the decode codecs: include timestamp in Message (or maybe Messages)
  • at the sink encode codec: histogram!(sink_to_source_latency, sink=name_of_sink)
  • at the source encode codec: histogram!(source_to_sink_latency, source=name_of_source)

@rukai
Copy link
Member

rukai commented May 6, 2024

completed in #1395

@rukai rukai closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants