Move NodePool custom clone into a NodePoolBuilder #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbromhead
approved these changes
Feb 7, 2023
rukai
force-pushed
the
node_pool_builder
branch
from
4555d6b
to
ba2779c
Compare
conorbros
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodePoolBuilder matches the abstractions and naming used by CassandraSinkClusterBuilder. We no longer have a custom clone impl responsible for deciding which values are shared between transform instances.
unit tests no longer rely on a unit test specific code path (
NodePath::newwith a prepopulated vec), they now follow the same path to set the node list as the real code does (NodePath::update_nodes)