Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workspace deps #1030

Merged
merged 4 commits into from Feb 15, 2023
Merged

Workspace deps #1030

merged 4 commits into from Feb 15, 2023

Conversation

conorbros
Copy link
Member

@conorbros conorbros commented Feb 9, 2023 •
edited

Will land #1028 first

@rukai
Copy link
Member

rukai commented Feb 9, 2023

Thanks for doing this! It'll make managing dependencies a lot easier

@conorbros conorbros marked this pull request as ready for review February 10, 2023 01:30
rukai
rukai approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rukai rukai merged commit d1c9085 into shotover:main Feb 15, 2023
@conorbros conorbros deleted the workspace-deps branch February 16, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rukai rukai rukai approved these changes

@benbromhead benbromhead benbromhead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@conorbros @rukai @benbromhead