Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid storing ConsistencyBehaviour::SubchainOnMismatch config in the final tee transform #1061

Merged
merged 1 commit into from Mar 1, 2023
Merged

Avoid storing ConsistencyBehaviour::SubchainOnMismatch config in the final tee transform #1061

merged 1 commit into from Mar 1, 2023

Conversation

rukai
Copy link
Member

@rukai rukai commented Feb 27, 2023 •
edited

This PR:

  • avoids invalid states by storing the chain in the ConsistencyBehavior enum itself
  • avoids cloning the mismatch chain config into every built tee

To achieve this a unique ConsistencyBehavior enum was created for every stage of the transform

@rukai rukai mentioned this pull request Feb 28, 2023
Merged
benbromhead
benbromhead approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@benbromhead benbromhead left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Definitely better from an encapsulation and data ownership perspective

@conorbros conorbros merged commit a47c5d6 into shotover:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbromhead benbromhead benbromhead approved these changes

@conorbros conorbros conorbros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rukai @benbromhead @conorbros