Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topology building cleanup #1067

Merged
merged 2 commits into from Mar 8, 2023
Merged

Topology building cleanup #1067

merged 2 commits into from Mar 8, 2023

Conversation

rukai
Copy link
Member

@rukai rukai commented Mar 7, 2023

  • from_yaml was used by a test but it could just as easily use the standard from_file so I just replaced it
  • TopologyConfig and Topology have the exact same fields so there is no point in keeping the separation anymore (they used to have different fields a long time ago)

@rukai rukai merged commit 60c77f6 into shotover:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants