New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CassandraSinkCluster improve get_replica_node_in_dc error type #1093

Merged

rukai merged 1 commit into shotover:main from rukai:improve_get_replica_node_in_dc_error_handling

Mar 21, 2023

Member

rukai commented Mar 21, 2023

It is easier to understand the error type if we add an extra error variant instead of nesting an extra Option in there.


          CassandraSinkCluster improve get_replica_node_in_dc error type

f0ec30e

rukai requested review from conorbros and benbromhead

March 21, 2023 01:13

benbromhead approved these changes

View reviewed changes

Member

benbromhead left a comment

Good catch

conorbros approved these changes

View reviewed changes

rukai merged commit 71c02c7 into shotover:main

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment