Cleanup shotover::Runner api #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
cleanup_shotover_runner_api
branch
2 times, most recently
from
6ae50bd
to
3c8d969
Compare
conorbros
reviewed
Mar 29, 2023
conorbros
reviewed
Mar 29, 2023
conorbros
approved these changes
Mar 29, 2023
rukai
force-pushed
the
cleanup_shotover_runner_api
branch
from
7346268
to
19e8b04
Compare
benbromhead
reviewed
Apr 3, 2023
rukai
force-pushed
the
cleanup_shotover_runner_api
branch
from
d28d654
to
292d95a
Compare
benbromhead
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To give custom transform users a nicer setup process.
List of changes:
with_observability_interface, this method was originally added as a hack for specific integration tests but that hack is no longer needed so the function can just be removed and the observability interface always enabled.Runner::new()now internally performs the backup tracing reporter logic that was previously inshotover-proxy/src/main.rs!Runnerrenamed toShotoveras from the users perspective that type is shotover.We could have just done a single
run_shotover()method butShotover::new().run_block()adds barely any more complication and gives us room to expand without breaking changes in the future.