Fix main #1115
Merged
Fix main #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that force merging this will fix our CI failures.
The problem only manifests itself when our benchmark comparison script runs the PREVIOUS commits benchmarks.
Thats how it managed to slip past our rigorous checks that everything passes on main before merging.
As such we will need to cross our fingers and force merge this PR and see if it fixes the issue.
However I am fairly confident this is the correct fix as #1111 clearly introduced the issue and I can see that it failed to initialize the benchmark properly.