-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CassandraSinkCluster replace recv with try_recv #1553
Merged
rukai
merged 4 commits into
shotover:main
from
rukai:cassandra_sink_cluster_port_to_connection
Apr 18, 2024
Merged
CassandraSinkCluster replace recv with try_recv #1553
rukai
merged 4 commits into
shotover:main
from
rukai:cassandra_sink_cluster_port_to_connection
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
changed the title
CassandraSinkCluster port to Connection
CassandraSinkCluster port to SinkConnection
Mar 26, 2024
rukai
force-pushed
the
cassandra_sink_cluster_port_to_connection
branch
3 times, most recently
from
April 2, 2024 23:05
54bdacc
to
b4e1e0c
Compare
rukai
force-pushed
the
cassandra_sink_cluster_port_to_connection
branch
3 times, most recently
from
April 3, 2024 05:15
a5e1525
to
0c3caab
Compare
This was referenced Apr 3, 2024
rukai
force-pushed
the
cassandra_sink_cluster_port_to_connection
branch
4 times, most recently
from
April 4, 2024 02:00
9c4fe8a
to
ed4e668
Compare
rukai
force-pushed
the
cassandra_sink_cluster_port_to_connection
branch
4 times, most recently
from
April 5, 2024 00:17
5f27e17
to
2217c08
Compare
rukai
changed the title
CassandraSinkCluster port to SinkConnection
CassandraSinkCluster replace recv with try_recv
Apr 5, 2024
rukai
force-pushed
the
cassandra_sink_cluster_port_to_connection
branch
4 times, most recently
from
April 5, 2024 05:08
6670751
to
28f1457
Compare
rukai
force-pushed
the
cassandra_sink_cluster_port_to_connection
branch
3 times, most recently
from
April 16, 2024 23:18
2284eea
to
da19bea
Compare
rukai
force-pushed
the
cassandra_sink_cluster_port_to_connection
branch
from
April 17, 2024 21:55
da19bea
to
a609834
Compare
cjrolo
approved these changes
Apr 18, 2024
benbromhead
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This was referenced May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR swaps CassandraSinkCluster from recv to try_recv for the performance improvements it brings:
Looks like a large win for connection_count=1
And when comparing against benches without shotover in the loop we can see that shotover is now very close!
connection_count = 1 has shotover lagging behind by about 20-30%
connection_count = 10 has slightly higher throughput for shotover (in reality thats probably just noise)
connection_count = 100 is also pretty much identical.