Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite CI, fixing caching and failing on warnings #333

Merged
merged 1 commit into from Nov 1, 2021

Conversation

rukai
Copy link
Member

@rukai rukai commented Oct 31, 2021

closes #323
My conclusion here is that the AWS + sccache solution would be a bit better, but using the GA cache is easier to setup and manage.
So if we find the GA cache limiting we can investigate going back to AWS + sccache.

The other changes are:

  • failing on clippy warnings
    • we can do this because we are now specifying a rust version in the rust-toolchain.toml and we already have our Cargo.lock checked in so there is no way for our build to break due to warnings being added.
      • The expectation here is that we will update the rust-toolchain.toml every time a new rust version comes out to take advantage of the speed ups and UX improvements not to mention new features.
  • changes the toolchain installer to be a little more efficient and added a comment explaining why we are still wasting some time installing a toolchain we dont use.
  • installs cargo-hack so that we can use it for the clippy check allowing us to test every possible feature combination.
  • removes the manual docker cleanup - not sure why this existed ... surely the whole VM gets destroyed when we finish anyway.

All the actual code changes are to fix clippy warnings that we weren't hitting locally due to not including --all-targets.

@rukai rukai changed the title rewrite CI fixing caching and failing on warnings rewrite CI, fixing caching and failing on warnings Oct 31, 2021
@rukai rukai force-pushed the rewrite_ci branch 3 times, most recently from db35fd0 to d6537d8 Compare November 1, 2021 00:24
@github-actions
Copy link

github-actions bot commented Nov 1, 2021

1 benchmarks reported regressed performance. Please check the benchmark workflow logs for details: https://github.com/shotover/shotover-proxy/actions/runs/1405926704

@github-actions
Copy link

github-actions bot commented Nov 1, 2021

2 benchmarks reported regressed performance. Please check the benchmark workflow logs for details: https://github.com/shotover/shotover-proxy/actions/runs/1406008318

Copy link
Member

@conorbros conorbros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI speedup is very appreciated

@conorbros conorbros merged commit 32ea744 into shotover:main Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix CI caching
3 participants