rewrite CI, fixing caching and failing on warnings #333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #323
My conclusion here is that the AWS + sccache solution would be a bit better, but using the GA cache is easier to setup and manage.
So if we find the GA cache limiting we can investigate going back to AWS + sccache.
The other changes are:
All the actual code changes are to fix clippy warnings that we weren't hitting locally due to not including
--all-targets
.