Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer #50

Merged
merged 3 commits into from Sep 16, 2020
Merged

Buffer #50

merged 3 commits into from Sep 16, 2020

Conversation

benbromhead
Copy link
Member

This PR does the following:

  • Initial work to introduce buffered communication between transforms if needed. Via the renamed Buffer and Tee transforms (the old MPSC stuff).
  • Users have the option to make this synchonous or not (wait for a response or not).
  • removes the message clock concept and now expects transforms to own the later message issue (e.g. by using channels)

@benbromhead
All the channels
388e0f1 
Support the following:
sync channels
groundwork to remove message clock
@benbromhead
notes
3c67e89
@benbromhead
Remove Message clock
b12aac0
@benbromhead
Copy link
Member Author

This PR will close #46

@benbromhead benbromhead linked an issue Sep 16, 2020 that may be closed by this pull request
Refactor message clock #46
Closed
@benbromhead benbromhead added this to In progress in Chain Structure Refactor via automation Sep 16, 2020
@benbromhead benbromhead added the enhancement New feature or request label Sep 16, 2020
@benbromhead benbromhead self-assigned this Sep 16, 2020
@benbromhead benbromhead merged commit 06d7765 into main Sep 16, 2020
Chain Structure Refactor automation moved this from In progress to Done Sep 16, 2020
@benbromhead benbromhead deleted the buffer branch October 29, 2020 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@benbromhead benbromhead

Labels
enhancement New feature or request
Projects
No open projects
Chain Structure Refactor
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor message clock
1 participant
@benbromhead