Numerous Fixes #54
Merged
Numerous Fixes #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
benbromhead
commented
Sep 22, 2020
benbromhead
commented
- Makes hardcoded connection limiting configurable + increases default to 512 (was 50)
- Removes no longer needed nightly feature requirements. Can now build shotover with stable.
- Allows the MPSC source to return a response via the associated one shot channel.
This commit does the following: * Fixes hardcoded connection limiting * Removes no longer needed nightly feature requirements * Allows the MPSC source to return a response via the associated one shot channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.