Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable parallelization of packet parsing in packet tests #600

Merged
merged 1 commit into from Apr 6, 2022

Conversation

rukai
Copy link
Member

@rukai rukai commented Apr 6, 2022

Ended up down this rabbit hole because I went to remove the num_cpus dep as its now built into rust 1.59, however discovered that we didnt need it at all in the first place.

  • Removes commented out code + dependencies used by commented out code
  • Reduces test runtime by 10s by parallelizing the workload, theres still 10s of runtime left that could be optimized but I dont have high confidence in the approach of this test in the first place so i'll leave as is.
  • Simplifies implementation, rayon is much simpler to use than raw Threadpools

@rukai rukai force-pushed the remove_debt_from_packet_tests branch 2 times, most recently from b053447 to d121087 Compare April 6, 2022 02:59
@shotover shotover deleted a comment from github-actions bot Apr 6, 2022
@rukai rukai force-pushed the remove_debt_from_packet_tests branch from d121087 to 1b2fe1c Compare April 6, 2022 03:58
@rukai rukai force-pushed the remove_debt_from_packet_tests branch from 1b2fe1c to 0728ae5 Compare April 6, 2022 06:31
@rukai rukai enabled auto-merge (squash) April 6, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants