Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CassandraSinkCluster query system.local for local node info #735

Merged
merged 3 commits into from Aug 16, 2022

Conversation

rukai
Copy link
Member

@rukai rukai commented Aug 10, 2022

The change to the integration test demonstrates the change: we are now representing the entire cluster in the nodes list, previously we only included the 2 peers of the node we are querying but now we include the node itself as well.

Additionally I improved the error handling by:

  • system_peers_into_node now returns errors for cases that are unrecoverable instead of silently ignoring the case.
    • A nice improvement this will bring is CassandraOperation::Errors are now logged - a possible case that could cause that is an auth error which is a realistic case.
  • Retry querying the same peer 3 times and then move onto another handshake provided by another clients connection.

The old QueryParams values were blindly copy pasted in and on closer inspection they are not very good. e.g. page_size and timestamp should not be set.
I used the QueryParams::default because all of the default values happen to be exactly what we want.

@rukai rukai force-pushed the query_sytem_local branch 2 times, most recently from 07081f4 to f24d193 Compare August 15, 2022 04:08
@github-actions
Copy link

1 benchmark regressed. 0 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/2864967056

cassandra/passthrough_parse_response_select
                        time:   [908.03 us 929.73 us 952.70 us]
                        thrpt:  [1.0496 Kelem/s 1.0756 Kelem/s 1.1013 Kelem/s]
                 change:
                        time:   [+21.698% +25.779% +30.211%] (p = 0.00 < 0.05)
                        thrpt:  [-23.201% -20.496% -17.830%]
                        Performance has regressed.

@conorbros conorbros merged commit d19e190 into shotover:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants