Fix intermittent failure (final I swear) #738
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had originally thought that failures were a rare edge case that we should handle individually.
However its become clear that approach wont work.
To fix this issue once and for all I have replaced the illadvised SchemaAwaiter abstraction with logic in our CassandraConnection::execute method that will check for any schema altering commands and call await_schema_agreement() to block until the schema altering command is truly complete.
The rest of the PR should be just asyncification noise