ConnectionFactory #755
Merged
ConnectionFactory #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorbros
force-pushed
the
connection-factory
branch
2 times, most recently
from
6ba41a5
to
f71840a
Compare
conorbros
force-pushed
the
connection-factory
branch
from
f71840a
to
61c9f92
Compare
conorbros
force-pushed
the
connection-factory
branch
2 times, most recently
from
a74d193
to
790da92
Compare
rukai
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
I'm not 100% confident this is the best way to organize this state.
My main concern is the multiple clone implementations that clone various internal state, you have to understand the internals of these functions to know which one is the right one to call.
Edit: Oh the new name is clearer, I missed that before.
But the new abstraction does also have some advantages so... LGTM 👍
conorbros
force-pushed
the
connection-factory
branch
from
790da92
to
d2ff5c1
Compare
benbromhead
approved these changes
Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change pulled from the
NodePoolPR. No functional changes, just encapsulates the logic for creating new connections.