Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mpsc chain change #77

Merged
merged 4 commits into from
Dec 4, 2020
Merged

Mpsc chain change #77

merged 4 commits into from
Dec 4, 2020

Conversation

benbromhead
Copy link
Member

  • changes the way MPSC uses topics, it will now have its own chain and will create a new channel for each connection, rather than putting everything into the one channel
  • this means buffer sizes are per connection (less likely to fill up, if they do, only impacts one client)
  • example config will now block on pushing to the MPSC tee (this is configurable), with the timeout being enforced downstream
  • this (small) amount of back pressure results in way less messages being dropped, for a tradeoff in throughput, but way more reliable

@benbromhead benbromhead merged commit fbb88f8 into main Dec 4, 2020
@benbromhead benbromhead deleted the mpsc-chain-change branch December 20, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant