CassandraSinkCluster: Document desired error handling #875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents what shotover's error handling for CassandraSinkCluster should look like.
Currently we dont handle in the way described here, but I wanted us to agree on an error handling approach that seemed reasonable and that we can work towards. We can of course change things later if we find we need to though.
We could also return an overloaded error when a connection error occurs before sending the message as that would simplify shotover by letting us push retries onto the client.