New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove docker-compose healthcheck from int tests #883

Merged

rukai merged 2 commits into shotover:main from rukai:remove_healthcheck

Oct 26, 2022

Member

rukai commented Oct 25, 2022

The healthcheck doesnt bring anything to our integration tests:

It doesnt run on startup so doesnt help check our startup succeeded
running during the integration test is not helpful because we already have our tests assertions ensuring that the nodes are still healthy


          remove docker-compose healthcheck from int tests

7274ff3

rukai requested review from conorbros and benbromhead

October 25, 2022 02:59

XA21X approved these changes

View reviewed changes

benbromhead approved these changes

View reviewed changes


          Merge branch 'main' into remove_healthcheck

457da3f

rukai enabled auto-merge (squash)

October 26, 2022 02:31

rukai merged commit a3dfabd into shotover:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment