cassandra_int_tests: add node lost test case #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is working now, I believe it was fixed by: #873 |
conorbros
reviewed
Nov 3, 2022
benbromhead
approved these changes
Nov 3, 2022
conorbros
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently test when the node shutsdown cleanly and therefore notifies its peers and therefore shotover of the node going down.
However we didnt test the case where the node silently dissapears requiring shotover to detect the missing node itself.
This PR adds that test case.
It needs to be added as a separate test case because the existing call to
test_node_going_downleaves the cluster in a bad state.Still need to investigate and fix the problem this reveals.But dumping this here as a draft as I'm working on something else first.