Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix redis error reporting #898

Merged
merged 1 commit into from Nov 4, 2022
Merged

fix redis error reporting #898

merged 1 commit into from Nov 4, 2022

Conversation

rukai
Copy link
Member

@rukai rukai commented Nov 4, 2022 •
edited

Using {} instead of {:?} was preventing the full error chain from being logged.
Also replaced some custom string formatting with anyhow context method.

@rukai rukai requested review from XA21X and conorbros November 4, 2022 06:32
@rukai rukai merged commit 6976fef into shotover:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XA21X XA21X XA21X approved these changes

@conorbros conorbros conorbros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rukai @XA21X @conorbros