Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS: Use destination as hostname instead of hardcoded localhost #899

Merged
merged 1 commit into from Nov 9, 2022

Conversation

rukai
Copy link
Member

@rukai rukai commented Nov 4, 2022

Theres a few things going on here:

  • TlsConnector::connect now creates its own TcpStream - this enforces that the hostname is derived from the address.
  • All cluster examples have verify_hostname disabled because clusters rely on ip address communication and openssl hostname verification will fail verification on IP addresses (it only allows domain names)

@rukai rukai enabled auto-merge (squash) November 8, 2022 09:58
@rukai rukai merged commit c8c8772 into shotover:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants