Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scylla Driver Tests #902

Merged
merged 3 commits into from Nov 8, 2022
Merged

Scylla Driver Tests #902

merged 3 commits into from Nov 8, 2022

Conversation

conorbros
Copy link
Member

Finish implementing the Scylla driver test helpers and add it to the test suite.

@conorbros conorbros marked this pull request as ready for review November 8, 2022 02:05
@conorbros conorbros requested a review from rukai November 8, 2022 02:05
rukai
rukai approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Its great to finally have most of our tests running against more than one driver. 🎉

@conorbros conorbros merged commit 3bd9bc6 into shotover:main Nov 8, 2022
@conorbros conorbros deleted the scylla-driver-tests branch November 8, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rukai rukai rukai approved these changes

@benbromhead benbromhead benbromhead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@conorbros @rukai @benbromhead