Add warning to rewritten queries with WHERE #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XA21X
reviewed
Nov 11, 2022
XA21X
approved these changes
Nov 11, 2022
conorbros
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #779
There has been a fair bit of confusion over the behavior of these tables with WHERE clauses and these warnings should make it obvious to the user where shotovers handling falls short.
I also made the final warnings list include all warnings from extra queries that were sent in order to generate the final query.
Currently this new warning produces a lot of noise in our integration tests as the drivers do use a WHERE clause forsystem.local.I think the correct fix for this noise would be to specifically handle certain WHERE clauses that drivers are known to make.
Probably want to delay merging this until we have a fix for that though.
I fixed the noise by adding specific logic to ignore the common
FROM system.local WHERE key = 'local'thing that drivers keep inexplicably doing.e.g. here is the PR that adds the query to scylla-rust-driver scylladb/scylla-rust-driver#223