Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cassandra connection avoid cloning entire message #913

Merged
merged 4 commits into from Nov 15, 2022

Conversation

rukai
Copy link
Member

@rukai rukai commented Nov 15, 2022

The connection logic was previously cloning the entire message when it really needed was the stream_id and version fields.
I removed the message clone and changed the connection logic to get the values from:

  • stream_id - Sent to the rx task where the original message used to be.
  • version - The transform is now responsible for keeping track of the version. Its constant per connection, so we can just set it once from the first message and it will always be the same.

This is a prereq for cassandra error handling improvements.

@rukai rukai force-pushed the cassandra_response_avoid_clone branch from c489737 to 27672b6 Compare November 15, 2022 03:38
@rukai rukai force-pushed the cassandra_response_avoid_clone branch from 27672b6 to 58b2ac4 Compare November 15, 2022 03:59
@rukai rukai force-pushed the cassandra_response_avoid_clone branch from 0939472 to 6a643bf Compare November 15, 2022 06:05
@rukai rukai merged commit 65066c2 into shotover:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants